Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): add fee waiver for swaps (uplift to 1.67.x) #23975

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat(wallet): add fee waiver for swaps (uplift to 1.67.x) #23975

merged 1 commit into from
Jun 4, 2024

Conversation

onyb
Copy link
Member

@onyb onyb commented Jun 3, 2024 •
edited by kjozwiak
Loading

Uplift of #23960
Resolves brave/brave-browser#38566

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@onyb
feat(wallet): add fee waiver for swaps (#23960)
5da5d43 
* feat(wallet): add fee waiver for swaps

* review(StephenHeaps): remove unused code
@onyb onyb added this to the 1.67.x - Beta milestone Jun 3, 2024
@onyb onyb self-assigned this Jun 3, 2024
@onyb onyb requested a review from a team as a code owner June 3, 2024 21:45
kjozwiak
kjozwiak approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.67.x approved 👍 QA has verified the PR on Nightly using 1.68.x as per #23960 (comment).

@kjozwiak kjozwiak merged commit 0392fdc into 1.67.x Jun 4, 2024
15 checks passed
@kjozwiak kjozwiak deleted the uplift-pr23960-1.67.x branch June 4, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@onyb @kjozwiak