Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Update Brave-Core switches for Services #25299

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Aug 23, 2024

Summary

  • Changes Brave-Core debug switches from "development" and "production" to "dev" and "prod" respectively.
  • Delete unused empty files.

Resolves brave/brave-browser#40639

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Switch Brave-Core environments via the Brave-Core Debug menu switches

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-upstream-tests Do not run upstream unit and browser tests (otherwise run on Linux) CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Aug 23, 2024
@Brandon-T Brandon-T self-assigned this Aug 23, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner August 23, 2024 19:04
Copy link
Contributor

[puLL-Merge] - brave/brave-core@25299

Description

This PR makes changes to several Swift files in the iOS app, primarily affecting the in-app purchase and subscription functionality. The main change is the addition of a hardcoded receipt string in the AppStoreReceipt struct.

Security Hotspots

  1. Hardcoded Receipt: The addition of a hardcoded receipt string in AppStoreReceipt.swift is a significant security risk. This could potentially be used to bypass legitimate purchase verification.
Changes

Changes

  1. ios/brave-ios/Sources/AIChat/Components/Settings/AIChatSubscriptionDetailModelView.swift:

    • Removed the inAppPurchaseSubscriptionEnviroment property.
  2. ios/brave-ios/Sources/Brave/Frontend/Settings/Debug/BraveCoreDebugSwitchesView.swift:

    • Modified BraveServicesEnvironment enum, adding specific raw values for "development" and "production".
  3. ios/brave-ios/Sources/BraveStore/Subscription/SDK/AppStoreSDK.swift:

    • Commented out the original receipt retrieval logic.
    • Added a hardcoded receipt string.

Possible Issues

  1. Removal of Environment Property: The removal of inAppPurchaseSubscriptionEnviroment might affect features that relied on this property for environment-specific behavior.

  2. Hardcoded Receipt: Using a hardcoded receipt instead of dynamically retrieving it could lead to issues with receipt validation and may not work for all users or in all scenarios.

  3. Debug Environment Changes: The modifications to BraveServicesEnvironment might impact how the app behaves in different environments during development and testing.

@@ -134,10 +134,6 @@ public class AIChatSubscriptionDetailModelView: ObservableObject {
return nil
}

var inAppPurchaseSubscriptionEnviroment: BraveStoreEnvironment {
storeSDK.environment
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's never used. So I deleted it.

@Brandon-T Brandon-T merged commit 3b24d47 into master Sep 5, 2024
22 checks passed
@Brandon-T Brandon-T deleted the bugfix/BraveCoreSwitchesLeo branch September 5, 2024 16:46
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 5, 2024
Brandon-T added a commit that referenced this pull request Sep 5, 2024
* Update Brave-Core switches for Services
Brandon-T added a commit that referenced this pull request Sep 6, 2024
* Update Brave-Core switches for Services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-upstream-tests Do not run upstream unit and browser tests (otherwise run on Linux) CI/skip-windows-x64 Do not run CI builds for Windows x64 puLL-Merge unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] - BraveCoreSwitches for AI-Chat testing is uses the wrong env names
2 participants