Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Sponsored Images & Videos option to New Tab Page setting (uplift to 1.70.x) #25326

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Aug 26, 2024

Uplift of #25108
Uplift of #25175
Uplift of #25285

Resolves brave/brave-browser#38198
Resolves brave/brave-browser#40507
Resolves brave/brave-browser#40605

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

[ads] Add Sponsored Images & Videos option to New Tab Page setting
[ads] Add NTP media type p3a metric
[ads] Fix NTT video background may be blank after changing NTP media type setting
@aseren aseren requested a review from a team as a code owner August 26, 2024 17:59
@aseren aseren added this to the 1.70.x - Beta milestone Aug 26, 2024
@btlechowski
Copy link

Verification passed on Brave v1.71.64 on iPhone 13 Pro Max (iOS 17.5.1)

brave/brave-browser#38198

Clean profile - first run - JP region in phone

Verified Media Type menu is shown for JP region and Sponsored Images & Videos is default one

image

Verified it has 3 options and Sponsored Images & Videos is default one

image

Verified video ad is shown

image

Clean profile - first run - JP region in phone - Sponsored Images

Verified video ad is not shown

Clean profile - first run - JP region in phone - Default Images

Verified video ad is not shown

Clean profile - changing locale

After changing locale to DE from JP, Sponsored Images is not selected, Logged

image

But Sponsored images are shown:
image

Clean profile - Enabled rewards - JP geolocation

Verified Media Type menu is shown for JP geolocation and Sponsored Images & Videos is default one

image

Enabled rewards - JP->US geolocation - default value

Verified Media Type menu is shown for US geolocation and Sponsored Images is default one

image

Enabled rewards - JP->US->JP geolocation - default value

Verified Media Type menu is shown for JP geolocation and Sponsored Images & Videos is default one

image

Enabled rewards - JP->US geolocation - Default Images

Verified Media Type menu is shown for US geolocation and Default Images is default one

image

Enabled rewards - JP->US->JP geolocation - Default Images

Verified Media Type menu is shown for JP geolocation and Default Images is default one

image

Enabled rewards - JP->US->JP geolocation - Sponsored Images

Verified Media Type menu is shown for JP geolocation and Sponsored Images is default one

image image image

upgrade - Default Images

On 1.70.x:

image

On 1.71.x

image

upgrade - Sponsored Images

On 1.70.x:
image

On 1.71.x
image

brave/brave-browser#40605

Verified test plan from brave/brave-browser#40605

Verified NTT video background is not empty

brave/brave-browser#40507

Brave.NTP.SponsoredMediaType - disabled

image

Brave.NTP.SponsoredMediaType - images

image

Brave.NTP.SponsoredMediaType - images & videos

image

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.70.x approved 👍 QA has verified the PR on Nightly using 1.71.x as per #25326 (comment).

@kjozwiak kjozwiak merged commit 013b4ee into 1.70.x Sep 6, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr25108_sponsored_video_setting_1.70.x branch September 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants