Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Update the JitsiMeetSDK #25417

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[iOS] - Update the JitsiMeetSDK #25417

merged 2 commits into from
Sep 5, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Sep 3, 2024

Resolves brave/brave-browser#40829

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Test that Brave-Talk still works fine

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 3, 2024
@Brandon-T Brandon-T self-assigned this Sep 3, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner September 3, 2024 19:38
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only includes a WebRTC bump, I don't see any updates to third_party/ios_deps/JitsiMeet/JitsiMeetSDK.xcframework

You can grab it here https://github.com/jitsi/jitsi-meet-ios-sdk-releases/tree/master/lite/Frameworks

Copy link
Contributor

github-actions bot commented Sep 5, 2024

[puLL-Merge] - brave/brave-core@25417

Description

This PR updates the JitsiMeet SDK for iOS, including changes to the WebRTC dependency and various bundle resources. The main changes involve updating localization files, adding privacy bundles, and modifying framework information.

Changes

Changes

  1. WebRTC Dependency Update:

    • Updated the WebRTC revision from a52d059956976c2cba24b6b29ef1edfaf4c9cadf to 7c9f8e712da4d399f85f0a9bfec17f0a68ceb1fd in Package.resolved.
  2. JitsiMeetSDK Framework Changes:

    • Replaced AccessibilityResources.bundle with FBLPromises_Privacy.bundle and Promises_Privacy.bundle.
    • Added RCTI18nStrings.bundle with localization files for multiple languages.
    • Added RNCAsyncStorage_resources.bundle.
    • Updated Info.plist files for various bundles.
    • Modified binary files, including JitsiMeetSDK and Swift module files.
  3. Localization Updates:

    • Added localization files (Localizable.strings and fbt_language_pack.bin) for numerous languages, including Arabic, Czech, Danish, German, Greek, Spanish, Finnish, French, Hebrew, Hindi, Croatian, Hungarian, Indonesian, Italian, Japanese, Korean, Malay, Norwegian, Dutch, Polish, Portuguese, Romanian, Russian, Slovak, Swedish, Thai, Turkish, Ukrainian, Vietnamese, Chinese (Simplified and Traditional), and Zulu.
  4. Privacy Information:

    • Added PrivacyInfo.xcprivacy files to various bundles, likely to comply with App Store privacy requirements.
  5. Framework Updates:

    • Updated the JitsiMeetSDK binary for both arm64 and x86_64 architectures.
    • Modified Swift module documentation files.

These changes suggest an update to the JitsiMeet SDK with improved localization support, privacy enhancements, and possibly new features or bug fixes in the core SDK functionality.

@Brandon-T Brandon-T merged commit 689a596 into master Sep 5, 2024
17 checks passed
@Brandon-T Brandon-T deleted the update/JitsiMeetSDK branch September 5, 2024 22:25
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 5, 2024
brave-builds added a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 puLL-Merge unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] - Update JitsiMeetSDK
2 participants