Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(wallet): Segmented Control Sizing and Padding #25428

Merged

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Sep 4, 2024

Description

Fixes the Segmented Controls sizing and padding in the Wallet

Resolves brave/brave-browser#40718

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. There should not be big vertical Padding on the Segmented Controls on the Portfolio, Portfolio Asset, Edit Visible Asset, Explorer and Account Details views.
  2. The Segmented Controls should be smaller in the Panel on the Portfolio, Portfolio Asset, Edit Visible Asset, Explorer and Account Details views.

Portfolio

Before:

image image

After:

image image

Portfolio Asset

Before:

image image

After:

image image

Edit Visible Assets

Before:

image image

After:

image image

Explorer

Before:

image image

After:

image image

Account Details

Before:

image image

After:

image image

@Douglashdaniel Douglashdaniel self-assigned this Sep 4, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner September 4, 2024 16:47
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Sep 4, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the style-wallet-segmented-control-sizing-and-padding branch from c595e2b to b06f3c2 Compare September 4, 2024 20:24
@Douglashdaniel Douglashdaniel force-pushed the style-wallet-segmented-control-sizing-and-padding branch from b06f3c2 to d095f2a Compare September 4, 2024 21:38
@Douglashdaniel Douglashdaniel merged commit 9b8418e into master Sep 5, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the style-wallet-segmented-control-sizing-and-padding branch September 5, 2024 14:55
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Wallet Portfolio Segmented Control Sizing
3 participants