Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NTP] Don't hide NTP stats or widgets for "short" windows #25429

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Sep 4, 2024

Resolves brave/brave-browser#39927

Screenshot 2024-09-04 at 12 52 03 PM

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 4, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning
Copy link
Contributor

Note: The failing test has been fixed in latest master

@zenparsing zenparsing merged commit 4a76e2f into master Sep 5, 2024
17 checks passed
@zenparsing zenparsing deleted the ksmith-ntp-tweakage branch September 5, 2024 14:50
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 5, 2024
brave-builds added a commit that referenced this pull request Sep 5, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 5, 2024

Verification Passed using

Brave | 1.71.63 Chromium: 128.0.6613.120 (Official Build) nightly (64-bit)
-- | --
Revision | 4a0d7016f41e2bd0dfc9daac94048ca066cbdf62
OS | Windows 11 Version 23H2 (Build 22631.4112)
  1. Installed 1.71.62
  2. launched Brave
  3. opened new tab page in an external monitor with default display settings
  4. verified stats, top sites, widgets, search widget etc are shown as expected
  5. move the window to 14" screen (or launch NTP independently in 14" screen)
  6. Confirmed stats, Talk, Rewards, Search widgets are shown
  7. Confirmed NTPSI images are shown
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR Follow up for small screens: Widgets & Stats are not shown for normal window in small screen
4 participants