Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated sync v2 flag #25437

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Removed deprecated sync v2 flag #25437

merged 1 commit into from
Sep 5, 2024

Conversation

bsclifton
Copy link
Member

The sync feature itself still exists and can be disabled via CLI. This is just the entry on brave://flags

Fixes brave/brave-browser#32450

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to brave://flags
  2. Verify the Enable Brave Sync v2 flag is gone

@bsclifton bsclifton self-assigned this Sep 4, 2024
@github-actions github-actions bot added the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Sep 4, 2024
The sync feature itself still exists and can be disabled via CLI. This
is just the entry on brave://flags

Fixes brave/brave-browser#32450
@bsclifton bsclifton merged commit 10078d4 into master Sep 5, 2024
17 checks passed
@bsclifton bsclifton deleted the bsc-remove-sync-flag branch September 5, 2024 18:04
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove brave-sync-v2 flag
2 participants