Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Refactor public facing enums to use mojom #25446

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 5, 2024

Resolves brave/brave-browser#34242

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please verify that the columns in the Defaults/ads_service/database.sqlite database are stored using snake_case and not camelCase. For example, ensure that the column is named notification_ad and not kNotificationAd. The specific database tables and columns to check are:

ad_events: type, confirmation_type (where type is the ad type)
ad_history: type, confirmation_type (where type is the ad type)
confirmation_queue: type, ad_type (where type is the confirmation type)
transactions: ad_type, confirmation_type

@tmancey tmancey self-assigned this Sep 5, 2024
@tmancey tmancey requested review from a team as code owners September 5, 2024 11:44
@tmancey tmancey changed the title Issues/34242 [ads] Refactor public facing enums to use mojom Sep 5, 2024
@tmancey tmancey force-pushed the issues/34242 branch 2 times, most recently from 50c7c91 to 4e6ccad Compare September 5, 2024 13:31
@tmancey tmancey force-pushed the issues/34242 branch 2 times, most recently from c40b6f2 to d5f95f7 Compare September 5, 2024 16:31
@tmancey tmancey merged commit 5388ecf into master Sep 6, 2024
17 checks passed
@tmancey tmancey deleted the issues/34242 branch September 6, 2024 06:59
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Refactor public facing enums to use mojom
4 participants