Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Swap Provider Icons #25451

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Douglashdaniel
Copy link
Contributor

Description

  • Fixes a bug where the Auto Brave Icon was missing when you open the Select Provider dropdown
  • Fixes a bug where the Li.Fi icon was broken when you select Li.Fi as an option

Resolves brave/brave-browser#40881

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Swap screen
  2. Open the Select Provider dropdown, the Brave icon should not be missing for Auto
  3. Select Li.Fi as the provider, the Li.Fi icon should not be broken after selection

Before:

Screen.Recording.mov

After:

Screen.Recording.1.mov

@Douglashdaniel Douglashdaniel self-assigned this Sep 5, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner September 5, 2024 15:46
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Sep 5, 2024
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit e99dccf into master Sep 5, 2024
18 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-swap-provider-icons branch September 5, 2024 18:38
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 5, 2024
brave-builds added a commit that referenced this pull request Sep 5, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2024

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.71.61 Chromium: 128.0.6613.120 (Official Build) nightly (64-bit)
-- | --
Revision | 97203b285c3fd120a2714727789be3b6ea8b91e6
OS | Windows 11 Version 23H2 (Build 22631.4112)

Using the STR/Cases outlined via #25451 (comment), ensured that the icons were being displayed under brave://wallet/swap under Auto as per the following:

Recording.2024-09-08.210400.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider Icons are broken for LiFi and Auto in Swap
4 participants