-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): Swap Provider Icons #25451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
Verification PASSED on
Using the STR/Cases outlined via #25451 (comment), ensured that the icons were being displayed under Recording.2024-09-08.210400.mp4 |
Uplift of #25451 (squashed) to beta
Description
Auto
Brave Icon was missing when you open theSelect Provider
dropdownLi.Fi
icon was broken when you selectLi.Fi
as an optionResolves brave/brave-browser#40881
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Wallet
and navigate to theSwap
screenSelect Provider
dropdown, theBrave
icon should not be missing forAuto
Li.Fi
as the provider, theLi.Fi
icon should not be broken after selectionBefore:
Screen.Recording.mov
After:
Screen.Recording.1.mov