Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced server selection ux (uplift to 1.70.x) #25465

Closed
wants to merge 1 commit into from
Closed

Advanced server selection ux (uplift to 1.70.x) #25465

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

Uplift of #25089
Resolves brave/brave-browser#36277
Resolves brave/brave-browser#38186

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 6, 2024 12:40
@brave-builds brave-builds added this to the 1.70.x - Beta milestone Sep 6, 2024
@brave-builds brave-builds self-assigned this Sep 6, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 6, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak reviewed Sep 8, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as per the discussion with @mattmcalister via https://bravesoftware.slack.com/archives/CC5SA8CCB/p1725622517174579. We'll let the above ride via 1.71.x.

@kjozwiak kjozwiak closed this Sep 8, 2024
@kjozwiak kjozwiak deleted the pr25089_advanced_server_selection_ux_1.70.x branch September 8, 2024 22:56
@kjozwiak kjozwiak removed this from the 1.70.x - Beta milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak