Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rewards non-connected state support text #25469

Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Sep 6, 2024

Resolves brave/brave-browser#40906

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick self-assigned this Sep 6, 2024
@emerick emerick requested review from a team as code owners September 6, 2024 17:10
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 6, 2024
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick merged commit 4fe7b8d into master Sep 6, 2024
18 checks passed
@emerick emerick deleted the emerick-rewards-update-non-connected-state-support-text-2 branch September 6, 2024 19:11
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 6, 2024
brave-builds added a commit that referenced this pull request Sep 6, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2024

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.71.74 Chromium: 128.0.6613.120 (Official Build) nightly (64-bit)
-- | --
Revision | 2eff1eb845b9fa44a4b9460fb5feed822a38b259
OS | Windows 11 Version 23H2 (Build 22631.4112)

Verification notes can be found via https://github.com/brave/internal/issues/1184#issuecomment-2339094326.

kjozwiak pushed a commit that referenced this pull request Sep 9, 2024
…25477)

* Uplift of #25469 (squashed) to beta

* Merge pull request #25486 from brave/emerick-rewards-update-non-connected-state-support-text-3

Correct capitalization in Rewards panel indirect support text

---------

Co-authored-by: Emerick Rogul <erogul@brave.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Indirect Support" text for non-connected users in Rewards 2.5 panel
5 participants