-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes an unneeded handler for input blur in Leo chat on Android #25475
Conversation
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
@@ -47,8 +47,7 @@ export default function BeginGeneration() { | |||
isMobile: false, | |||
hasAcceptedAgreement: true | |||
}} | |||
onFocusInputMobile={() => undefined} | |||
onBlurInputMobile={() => undefined} /> | |||
onFocusInputMobile={() => undefined} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst we're editing this, please can we fix this issue that onFocusInputMobile
isn't optional. Can be defined in input.tsx
as
onFocusInputMobile?: () => unknown
422e5b9
to
3087ce3
Compare
Verified on
STEPS:
ACTUAL RESULTS:
2024-09-10_09-39-15.mp4 |
Resolves brave/brave-browser#40893
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: