Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes an unneeded handler for input blur in Leo chat on Android #25475

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Sep 6, 2024

Resolves brave/brave-browser#40893

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@SergeyZhukovsky SergeyZhukovsky self-assigned this Sep 6, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 6, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@@ -47,8 +47,7 @@ export default function BeginGeneration() {
isMobile: false,
hasAcceptedAgreement: true
}}
onFocusInputMobile={() => undefined}
onBlurInputMobile={() => undefined} />
onFocusInputMobile={() => undefined} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst we're editing this, please can we fix this issue that onFocusInputMobile isn't optional. Can be defined in input.tsx as

onFocusInputMobile?: () => unknown

@SergeyZhukovsky SergeyZhukovsky merged commit 4028d01 into master Sep 9, 2024
17 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_leo_keyboard branch September 9, 2024 22:04
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 9, 2024
brave-builds added a commit that referenced this pull request Sep 9, 2024
@hffvld
Copy link
Collaborator

hffvld commented Sep 10, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240726.010 release-keys
Brave build: 1.71.76 
Chromium: 128.0.6613.120 (Official Build) canary (64-bit) 

STEPS:

  1. Launch Brave
  2. Open Leo
  3. Type any query
  4. Keep the on-screen keyboard opened > Tap /, Mic or Send button > Verify

ACTUAL RESULTS:

  • Verified that Leo's bottom panel buttons are tappable while the on-screen keyboard is opened.

2024-09-10_09-39-15.mp4

kjozwiak pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #40303] Buttons on Leo's bottom panel are not working until on-screen keyboard is closed
4 participants