Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix Tab-Bar plus icon not fitting #25481

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

Brandon-T
Copy link
Contributor

Resolves brave/brave-browser#40500

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 7, 2024
@Brandon-T Brandon-T self-assigned this Sep 7, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner September 7, 2024 00:28
@Brandon-T Brandon-T merged commit 43891cc into master Sep 9, 2024
18 checks passed
@Brandon-T Brandon-T deleted the bugfix/TabBarAddIcon branch September 9, 2024 19:51
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 9, 2024
brave-builds added a commit that referenced this pull request Sep 9, 2024
brave-builds added a commit that referenced this pull request Sep 9, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 10, 2024

Verified on iPad (7th Gen) running iOS 17.5.1 using version 1.71 (78)

  • Ensured that Tab Bar plus sign icon is not cut off.
  • Ensured tapping on the plus sign button will open a new tab.
  • Ensured tapping on the plus sign button will open a new tab with sponsored image without issues.
  • Ensured plus sign is not cut off in both orientations and change tabs or toggling tab view does not cause issues.
  • Ensured there are no issues with plus sign button on Tab Bar in Private mode
Example Example Example Example
IMG_1612 3 IMG_1615 3 IMG_1616 3 IMG_1617

kjozwiak pushed a commit that referenced this pull request Sep 10, 2024
kjozwiak pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plus sign button in tab bar is cut off [iPad]
3 participants