Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiline support for unverified state rewards #25489

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Sep 9, 2024

Resolves brave/brave-browser#40931

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Sep 9, 2024
@deeppandya deeppandya added this to the 1.71.x - Nightly milestone Sep 9, 2024
@deeppandya deeppandya self-assigned this Sep 9, 2024
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit 0d03756 into master Sep 9, 2024
18 checks passed
@deeppandya deeppandya deleted the add_multiline_support_rewards_title branch September 9, 2024 13:47
@kjozwiak
Copy link
Member

kjozwiak commented Sep 9, 2024

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.71.74 Chromium: 128.0.6613.120 (Official Build) canary (64-bit)
--- | ---
Revision | 2eff1eb845b9fa44a4b9460fb5feed822a38b259
OS | Android 15; Build/AP41.240726.010; 35; REL

Verification notes can be found via https://github.com/brave/internal/issues/1184#issuecomment-2339141370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Add multiline support in "Indirect Support" text for non-connected users in Rewards 2.5 panel
4 participants