Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(Privacy): Improve iOS Shields standard mode logic #25499

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Sep 9, 2024

Resolves brave/brave-browser#40967
Resolves https://github.com/brave/internal/issues/1188

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Sep 9, 2024
@StephenHeaps StephenHeaps self-assigned this Sep 9, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner September 9, 2024 23:57
@StephenHeaps StephenHeaps merged commit 40124bf into master Sep 10, 2024
17 checks passed
@StephenHeaps StephenHeaps deleted the bugfix/ios-shows-significant-text branch September 10, 2024 18:42
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Sep 10, 2024
brave-builds added a commit that referenced this pull request Sep 10, 2024
brave-builds added a commit that referenced this pull request Sep 10, 2024
kjozwiak pushed a commit that referenced this pull request Sep 11, 2024
kjozwiak pushed a commit that referenced this pull request Sep 11, 2024
@kjozwiak
Copy link
Member

Verification PASSED using iPhone 11 running iOS 17.6.1 using the following build(s):

Brave | 1.71.80 Chromium: 128.0.6613.120 (Official Build) nightly (64-bit) 
Revision | 4dea6843510d...
OS | iOS

Verification notes can be found via https://github.com/brave/internal/issues/1188#issuecomment-2342611739.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Standard Shields, significant text check should happen before partiness check
5 participants