Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes renderer crashes when JSON-LD contains a field with a null value #25518

Closed
wants to merge 1 commit into from

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Sep 11, 2024

Resolves brave/brave-browser#40983

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Sep 11, 2024
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Sep 11, 2024
@aseren
Copy link
Collaborator Author

aseren commented Sep 11, 2024

Closing as we are fixing it as chromium upstream

@aseren aseren closed this Sep 11, 2024
@aseren aseren changed the title [ads] Fixes SERP renderer crashes when JSON-LD contains a field with a null value [ads] Fixes renderer crashes when JSON-LD contains a field with a null value Sep 11, 2024
@aseren aseren changed the title [ads] Fixes renderer crashes when JSON-LD contains a field with a null value Fixes renderer crashes when JSON-LD contains a field with a null value Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renderer crashes when JSON-LD contains a field with a null value
1 participant