-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed plural issue in VPN server selection panel #25520
Conversation
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
fix brave/brave-browser#40987 "city" should be used for single city otherwise "cities" is used. "server" should be used for single server otherwise "servers" is used.
a2e03bc
to
48605ca
Compare
components/brave_vpn/resources/panel/components/select-region-list/index.tsx
Outdated
Show resolved
Hide resolved
48605ca
to
d4e095a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - sorry for the noise @simonhong
NP! I learned about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
fix brave/brave-browser#40987 "city" should be used for single city otherwise "cities" is used. "server" should be used for single server otherwise "servers" is used.
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#40987 (comment), ensured that we're using
|
fix brave/brave-browser#40987
"city" should be used for single city otherwise "cities" is used.
"server" should be used for single server otherwise "servers" is used.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See the linked issue.
Note: can't test single server count from product as we don't have region that has only one server.