[cr129 follow up] Adjust alignment of profile picker avatars.

[mkarolin]

Resolves brave/brave-browser#40964

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[mkarolin]

@fallaciousreasoning this gets the avatars aligned, but the on-hover shape of the button is not the entire card. I think that's coming from the nala button and I am uncertain how to tweak it.

[fallaciousreasoning]

Actually, does align-items: stretch; justify-content: stretch work?

[mkarolin]

Actually, does align-items: stretch; justify-content: stretch work?

Sadly, that doesn't work. It looks like the <button> inside the <leo-button> is styled with .leoButton.svelte-1mfuzhy.svelte-1mfuzhy which has max-height: max-content;. Disabling that and adding height: 100% would fix the <button> size.

[mkarolin]

Going to merge this and create a follow up issue to address the hover state.

[kjozwiak]

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.72.11 Chromium: 129.0.6668.42 (Official Build) nightly (64-bit)
-- | --
Revision | 13146b182b4f6abcce19429d54e41f4bae10ebe8
OS | Windows 11 Version 23H2 (Build 22631.4112)

Using the STR/Cases outlined via brave/brave-browser#40964 (comment), ensured that the profile picker has been correctly aligned as per the following:

Broken	Fixed

As mentioned via #25545 (comment), the hover state will be fixed by a follow up PR.