-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nala]: Fix Omnibox highlights and vertical tab separator with custom dark theme #25547
Conversation
@@ -702,8 +702,6 @@ void AddBraveOmniboxColorMixer(ui::ColorProvider* provider, | |||
|
|||
// We don't use bg color for location icon view. | |||
mixer[kColorPageInfoBackground] = {SK_ColorTRANSPARENT}; | |||
|
|||
AddOmniboxHoverSelect(mixer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now take the Chromium colors which is much simpler - we still need this for Private/Tor
@@ -693,7 +693,7 @@ void AddBraveOmniboxColorMixer(ui::ColorProvider* provider, | |||
const ui::ColorProviderKey& key) { | |||
ui::ColorMixer& mixer = provider->AddMixer(); | |||
|
|||
mixer[kColorBraveOmniboxResultViewSeparator] = {nala::kColorDividerSubtle}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not safe to use Nala theme variables without checking for a custom theme, unfortunately 😢
ed5c0c3
to
e9c6894
Compare
Verification
Reproduced the issue in 1.72.3
Light theme
Dark theme
Confirmed Selected result is not white ishHovering over results should not be white ishSeparator above Ask Leo should not be white ishConfirmed a separator between vertical tabs and the page is shown and it is not white
|
Resolves brave/brave-browser#40971
Resolves brave/brave-browser#41055
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Ask Leo
should not be white ish