-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix for safe browsing #25562
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "safe browsing" and so security team members have been added as reviewers to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
This is temporary fix to keep using safetynet for checking urls for safe browsing. We will have to change the way we handle it in C130 due to this change https://source.chromium.org/chromium/chromium/src/+/e5700c49b75254cc1201a3bbea59b20b06328a27
3ec5037
to
65f6e4e
Compare
Verification PASSED on
Using the STR/Cases brave/brave-browser#41060 (comment), ensured that the Webpage Warnings -
|
Example |
Example |
---|---|
Webpage Warnings - malware warning
- ensured that the
malware
warning is being displayed correctly - ensured that you can proceed past the warning without any issues
Example |
Example |
---|---|
Webpage Warnings - unwanted software warning
- ensured that the
unwanted software
warning is being displayed correctly - ensured that you can proceed past the warning without any issues
Example |
Example |
---|---|
Webpage Warnings - billing warning
- ensured that the
billing
warning is being displayed correctly - ensured that you can proceed past the warning without any issues
Example |
Example |
---|---|
Mobile Download Warnings - harmful file
- ensured that the
harmful file
modal is being displayed correctly - ensured that you can proceed past the warning and download the file without any issues
This is temporary fix to keep using safetynet for checking urls for safe browsing. We will have to change the way we handle it in C130 due to this change https://source.chromium.org/chromium/chromium/src/+/e5700c49b75254cc1201a3bbea59b20b06328a27
Resolves brave/brave-browser#41060
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: