Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix for safe browsing #25562

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[Android] Fix for safe browsing #25562

merged 1 commit into from
Sep 16, 2024

Conversation

samartnik
Copy link
Contributor

This is temporary fix to keep using safetynet for checking urls for safe browsing. We will have to change the way we handle it in C130 due to this change https://source.chromium.org/chromium/chromium/src/+/e5700c49b75254cc1201a3bbea59b20b06328a27

Resolves brave/brave-browser#41060

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Sep 13, 2024
@samartnik samartnik added this to the 1.72.x - Nightly milestone Sep 13, 2024
@samartnik samartnik self-assigned this Sep 13, 2024
@samartnik samartnik requested a review from a team as a code owner September 13, 2024 21:13
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Sep 13, 2024
Copy link
Contributor

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "safe browsing" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

This is temporary fix to keep using safetynet for checking urls for safe browsing. We will have to change the way we handle it in C130 due to this change https://source.chromium.org/chromium/chromium/src/+/e5700c49b75254cc1201a3bbea59b20b06328a27
@samartnik samartnik merged commit 69c80cd into master Sep 16, 2024
17 checks passed
@samartnik samartnik deleted the android_safe_browsing_fix branch September 16, 2024 13:07
brave-builds added a commit that referenced this pull request Sep 16, 2024
brave-builds added a commit that referenced this pull request Sep 16, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.72.13 Chromium: 129.0.6668.42 (Official Build) canary (64-bit)
--- | ---
Revision | d12479197db15ec73436d23bea8724b01103ef15
OS | Android 15; Build/AP41.240726.010; 35; REL

Using the STR/Cases brave/brave-browser#41060 (comment), ensured that the Safe Browsing was working as expected as per the following:

Webpage Warnings - phishing warning

  • ensured that the phishing warning is being displayed correctly
  • ensured that you can proceed past the warning without any issues
Example Example
1000002082 1000002083

Webpage Warnings - malware warning

  • ensured that the malware warning is being displayed correctly
  • ensured that you can proceed past the warning without any issues
Example Example
1000002084 1000002085

Webpage Warnings - unwanted software warning

  • ensured that the unwanted software warning is being displayed correctly
  • ensured that you can proceed past the warning without any issues
Example Example
1000002086 1000002087

Webpage Warnings - billing warning

  • ensured that the billing warning is being displayed correctly
  • ensured that you can proceed past the warning without any issues
Example Example
1000002088 1000002089

Mobile Download Warnings - harmful file

  • ensured that the harmful file modal is being displayed correctly
  • ensured that you can proceed past the warning and download the file without any issues

1000002091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix safe browsing
7 participants