fix(privacy): Add logic to record initial AdBlockSetting & FingerprintBlockSetting values #25582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brave.Shields.AdBlockSetting
was only being recorded when the value changed, not recording the initial value.Brave.Shields.FingerprintBlockSetting
was only being recorded when Shields settings was opened which may have missed initial value if user never opened shields settings.kCurrentReportRevision
to align with desktop logic, instead of existing boolean for easier updates later (increasekCurrentReportRevision
by 1 to re-record initial shields values).Resolves brave/brave-browser#41054
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
AdBlockSetting
&FingerprintBlockSetting
are both recorded at first launch