Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(privacy): Add logic to record initial AdBlockSetting & FingerprintBlockSetting values #25582

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

StephenHeaps
Copy link
Collaborator

  • Updated initial shields P3A value recordings to record 2 questions not reporting their initial value.
    • Brave.Shields.AdBlockSetting was only being recorded when the value changed, not recording the initial value.
    • Brave.Shields.FingerprintBlockSetting was only being recorded when Shields settings was opened which may have missed initial value if user never opened shields settings.
  • Additionally updated initial value function to add a kCurrentReportRevision to align with desktop logic, instead of existing boolean for easier updates later (increase kCurrentReportRevision by 1 to re-record initial shields values).

Resolves brave/brave-browser#41054

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Verify AdBlockSetting & FingerprintBlockSetting are both recorded at first launch
  2. Verify both are updated when value changes

@StephenHeaps StephenHeaps self-assigned this Sep 16, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner September 16, 2024 15:10
…erprintBlockSetting initial P3A values (in addition to when value changes).
@StephenHeaps StephenHeaps enabled auto-merge (squash) September 17, 2024 16:05
@StephenHeaps StephenHeaps merged commit a807c2f into master Sep 17, 2024
17 checks passed
@StephenHeaps StephenHeaps deleted the bugfix/ios-shields-p3a branch September 17, 2024 17:39
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 17, 2024
brave-builds added a commit that referenced this pull request Sep 17, 2024
brave-builds added a commit that referenced this pull request Sep 17, 2024
kjozwiak pushed a commit that referenced this pull request Sep 18, 2024
…tBlockSetting values (uplift to 1.71.x) (#25605)

Uplift of #25582 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Sep 18, 2024
…tBlockSetting values (uplift to 1.70.x) (#25606)

Uplift of #25582 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report more initial Shields P3A Values on Launch on iOS
3 participants