Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect NOTREACHED_IN_MIGRATION #25597

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove incorrect NOTREACHED_IN_MIGRATION #25597

merged 1 commit into from
Sep 17, 2024

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Sep 17, 2024

Resolves brave/brave-browser#41080
Partial Uplift of https://github.com/brave/brave-core/pull/24822/files#diff-13ef317f5eae76a6da0b8e8f3185c3b118cf8527bbf5bbcde3dde4e25120192aL828

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kjozwiak kjozwiak added this to the 1.70.x - Release milestone Sep 17, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.70.x approved 👍

@kjozwiak kjozwiak merged commit 5847849 into 1.70.x Sep 17, 2024
16 checks passed
@kjozwiak kjozwiak deleted the fix_41080_1_70 branch September 17, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants