Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add dark & tinted mode icons for iOS 18 #25603

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Sep 17, 2024

This change also updates the app icons to use a single size and let Xcode/iOS generate the required sizes since the icon itself is just scaled at the design side

Resolves brave/brave-browser#41088

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

On each channel (as CI makes appropriate builds):

  • Test that on iOS 18 the correct icons appear based on the selected appearance mode (light, dark, tinted)
  • Test that on iOS 16/17 the standard light mode app icon appears

This change also updates the app icons to use a single size and let Xcode/iOS generate the required sizes since the icon itself is just scaled at the design side
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Sep 17, 2024
@kylehickinson kylehickinson self-assigned this Sep 17, 2024
@kylehickinson kylehickinson requested a review from a team as a code owner September 17, 2024 15:55
Copy link
Contributor

[puLL-Merge] - brave/brave-core@25603

Description

This PR updates the app icons for the iOS version of Brave Browser. It simplifies the icon set by removing multiple sizes and introduces support for different appearances (light, dark, and tinted) for each app variant (main app, Beta, Local, and Nightly).

Changes

Changes

  1. ios/brave-ios/App/iOS/Icons.xcassets/AppIcon.appiconset/Contents.json

    • Removed multiple icon sizes for different devices
    • Added support for light, dark, and tinted appearances
    • Updated to use a single 1024x1024 icon for each appearance
  2. ios/brave-ios/App/iOS/Icons.xcassets/AppIcon_Beta.appiconset/Contents.json

    • Similar changes as the main AppIcon, supporting light, dark, and tinted appearances
  3. ios/brave-ios/App/iOS/Icons.xcassets/AppIcon_Local.appiconset/Contents.json

    • Similar changes as the main AppIcon, supporting light, dark, and tinted appearances
  4. ios/brave-ios/App/iOS/Icons.xcassets/AppIcon_Nightly.appiconset/Contents.json

    • Similar changes as the main AppIcon, supporting light, dark, and tinted appearances
  5. Icon files

    • Removed multiple smaller icon files for different sizes
    • Added new icon files for each appearance (light, dark, tinted) for each app variant
  6. ios/brave-ios/App/iOS/Icons.xcassets/AppIcon_Dev.appiconset

    • Removed the entire AppIcon_Dev.appiconset directory and its contents

Possible Issues

  1. Removal of multiple icon sizes might affect older iOS versions or devices that expect specific icon sizes. However, this is likely mitigated by iOS's ability to scale icons as needed.

  2. The removal of the AppIcon_Dev.appiconset might impact development builds if they were using these icons. Ensure that this doesn't break any development workflows.

  3. The new icon set relies on iOS's appearance settings (light, dark, tinted). Make sure that all supported iOS versions can handle these appearance-based icons correctly.

This PR significantly simplifies the app icon management for the iOS version of Brave Browser, which should make future icon updates easier. However, thorough testing on various iOS versions and devices is recommended to ensure compatibility and correct appearance across all scenarios.

@kylehickinson kylehickinson merged commit 599f552 into master Sep 17, 2024
18 checks passed
@kylehickinson kylehickinson deleted the ios-18-appicons branch September 17, 2024 20:46
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 17, 2024
brave-builds added a commit that referenced this pull request Sep 19, 2024
brave-builds added a commit that referenced this pull request Sep 19, 2024
kylehickinson pushed a commit that referenced this pull request Sep 20, 2024
kylehickinson pushed a commit that referenced this pull request Sep 20, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 20, 2024

Verified on iPhone 12 running iOS 18 using version 1.72 (27)

iOS 18 (Home Screen)

  • Verified Brave icon supports Light, Dark, Automatic and Tinted modes.
  • Verified Brave icons appearing correctly when using small and large icon setting in customization panel.
  • Verified using different tint configurations in Tinted mode is applied correctly.
  • Verified that Brave icon shows the correct mode when using automatic mode in the home screen customize menu.
  • Verified that Brave Widgets support the new Tinted mode.
light (small) dark (small) automatic (small) tinted (small)
IMG_7408 2 IMG_7408 IMG_7414 2 IMG_7415
light (large) dark (large) automatic (large) tinted (large)
IMG_7416 2 IMG_7417 2 IMG_7418 2 IMG_7419 2

iOS 18 Shortcuts, Dashboard + Search

  • Ensured that Brave icons that appear on Home Screen dash and when searching have the correct mode applied.
  • Ensured that tinted mode is applied for Shortcuts created and light/dark has not regressed for these.
example example example example example
IMG_7423 IMG_7424 IMG_7422 IMG_7430 IMG_7432

iOS 17

  • Ensured that Brave icon and widgets have not regressed for Light/Dark mode on iOS 17.x
Light Dark
IMG_0397 2 IMG_0398 2

iOS 16

  • Ensured that Brave icon and widgets have not regressed for Light/Dark mode on iOS 16.x
Dark Light
IMG_3854 IMG_3853

kjozwiak pushed a commit that referenced this pull request Sep 20, 2024
kjozwiak pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Dark Mode & Tinted Icons on iOS 18
3 participants