-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add dark & tinted mode icons for iOS 18 #25603
Conversation
This change also updates the app icons to use a single size and let Xcode/iOS generate the required sizes since the icon itself is just scaled at the design side
[puLL-Merge] - brave/brave-core@25603 DescriptionThis PR updates the app icons for the iOS version of Brave Browser. It simplifies the icon set by removing multiple sizes and introduces support for different appearances (light, dark, and tinted) for each app variant (main app, Beta, Local, and Nightly). ChangesChanges
Possible Issues
This PR significantly simplifies the app icon management for the iOS version of Brave Browser, which should make future icon updates easier. However, thorough testing on various iOS versions and devices is recommended to ensure compatibility and correct appearance across all scenarios. |
) Uplift of #25603 (squashed) to beta
) Uplift of #25603 (squashed) to release
This change also updates the app icons to use a single size and let Xcode/iOS generate the required sizes since the icon itself is just scaled at the design side
Resolves brave/brave-browser#41088
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
On each channel (as CI makes appropriate builds):