Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C129] [Android] Fix for url from share intent #25609

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

samartnik
Copy link
Contributor

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/6acaef7dbe9c5fce46e76a967bbc8605049de32a

Construct search URL from text share intent

Similar to getUrlFromVoiceSearchResult, share intent now be processed in getUrlFromIntent and be launched in tab later..

Bug: 343521057

Resolves brave/brave-browser#41089

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Sep 17, 2024
@samartnik samartnik added this to the 1.72.x - Nightly milestone Sep 17, 2024
@samartnik samartnik self-assigned this Sep 17, 2024
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS and removed CI/skip-ios Do not run CI builds for iOS labels Sep 17, 2024
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/6acaef7dbe9c5fce46e76a967bbc8605049de32a

Construct search URL from text share intent

Similar to getUrlFromVoiceSearchResult, share intent now be processed
in getUrlFromIntent and be launched in tab later..

Bug: 343521057
@samartnik samartnik merged commit edec664 into master Sep 18, 2024
17 checks passed
@samartnik samartnik deleted the android_share_intent_url_fix branch September 18, 2024 00:54
brave-builds added a commit that referenced this pull request Sep 18, 2024
brave-builds added a commit that referenced this pull request Sep 18, 2024
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.72.18 Chromium: 129.0.6668.42 (Official Build) canary (64-bit)
--- | ---
Revision | 2f1c293265db9b60d647bd2d4b73055b5cfb2d31
OS | Android 15; Build/AP41.240823.009; 35; REL

Reproduced the original issue using 1.72.17 Chromium: 129.0.6668.42 with the STR/Cases outlined via brave/brave-browser#41089 (comment) as per the following:

screen-20240918-020622.mp4

Using the same STR/Cases mentioned above, ensured that you can Share from the OS level including other applications like X with Brave without any issues as per the following:

screen-20240918-022414.mp4

kjozwiak pushed a commit that referenced this pull request Sep 18, 2024
kjozwiak pushed a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cr129] Websites can't be opened in Brave when using Android's native Share button
3 participants