-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C129] [Android] Fix for url from share intent #25609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Chromium change: https://source.chromium.org/chromium/chromium/src/+/6acaef7dbe9c5fce46e76a967bbc8605049de32a Construct search URL from text share intent Similar to getUrlFromVoiceSearchResult, share intent now be processed in getUrlFromIntent and be launched in tab later.. Bug: 343521057
42b77f0
to
be394f8
Compare
Verification PASSED on
Reproduced the original issue using screen-20240918-020622.mp4Using the same STR/Cases mentioned above, ensured that you can screen-20240918-022414.mp4 |
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/6acaef7dbe9c5fce46e76a967bbc8605049de32a
Construct search URL from text share intent
Similar to getUrlFromVoiceSearchResult, share intent now be processed in getUrlFromIntent and be launched in tab later..
Bug: 343521057
Resolves brave/brave-browser#41089
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: