Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Material]: Temporary override of sys-tonal-outline in devtools #25636

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Sep 18, 2024

Resolves brave/brave-browser#41128

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

@fallaciousreasoning fallaciousreasoning merged commit c39d2c2 into master Sep 18, 2024
18 checks passed
@fallaciousreasoning fallaciousreasoning deleted the rorange-devtools branch September 18, 2024 17:26
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 18, 2024
@fallaciousreasoning
Copy link
Contributor Author

This should be uplifted to 1.71

@LaurenWags
Copy link
Member

LaurenWags commented Sep 19, 2024

Verified with

Brave	1.72.21 Chromium: 129.0.6668.59 (Official Build) nightly (arm64) 
Revision	2b2ee22270175835e9fc0cc37a92b807ff968860
OS	macOS Version 15.0 (Build 24A335)

Reproduced the issue using 1.72.20 and STR from brave/brave-browser#41128 (comment).

Confirmed when using 1.72.21 and same STR the button is not orange.

1.72.20 1.72.21
1 72 20 1 72 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material UI]: Rorange button outline in devtools
3 participants