Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider IDS_PDF_OCR_IN_PROGRESS when checking whether PDF is loaded. (uplift to 1.70.x) #25638

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Consider IDS_PDF_OCR_IN_PROGRESS when checking whether PDF is loaded. (uplift to 1.70.x) #25638

merged 1 commit into from
Sep 19, 2024

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Sep 18, 2024 •
edited by kjozwiak
Loading

Uplift of #25619
Resolves brave/brave-browser#41127
Resolves brave/brave-browser#41065

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@darkdh
Merge pull request #25619 from brave/upstream-ocr-test
41df368 
Consider IDS_PDF_OCR_IN_PROGRESS when checking whether PDF is loaded.
@darkdh darkdh added this to the 1.70.x - Release milestone Sep 18, 2024
@darkdh darkdh self-assigned this Sep 18, 2024
@darkdh darkdh requested a review from a team as a code owner September 18, 2024 16:53
kjozwiak
kjozwiak approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.70.x approved 👍

@kjozwiak kjozwiak merged commit c0a235d into 1.70.x Sep 19, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr25619_upstream-ocr-test_1.70.x branch September 19, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@darkdh darkdh

Labels
None yet
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdh @kjozwiak