Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update filecoin-cxx deps, mainly multihash" #25658

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Sep 19, 2024

This reverts commit a1db616.

After merge, we started getting some issues in the CI relating to license files:

 FAILED: gen/components/resources/about_credits.html 
17:28:32  python3 ../../tools/licenses/licenses.py --target-os=linux --depfile gen/components/resources/about_credits.d credits gen/components/resources/about_credits.html
17:28:32  Traceback (most recent call last):
17:28:32    File "/home/ubuntu/workspace/brave-browser-build-linux-x64-nightly/src/out/Release/../../tools/licenses/licenses.py", line 1451, in <module>
17:28:32      sys.exit(main())
17:28:32               ^^^^^^
17:28:32    File "/home/ubuntu/workspace/brave-browser-build-linux-x64-nightly/src/out/Release/../../tools/licenses/licenses.py", line 1434, in main
17:28:32      if not GenerateCredits(
17:28:32             ^^^^^^^^^^^^^^^^
17:28:32    File "/home/ubuntu/workspace/brave-browser-build-linux-x64-nightly/src/out/Release/../../tools/licenses/licenses.py", line 1039, in GenerateCredits
17:28:32      ReportBraveIncompleteMetadataFile(path)
17:28:32    File "/home/ubuntu/workspace/brave-browser-build-linux-x64-nightly/src/brave/script/brave_license_helper.py", line 353, in ReportBraveIncompleteMetadataFile
17:28:32      raise ValueError(
17:28:32 

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium self-assigned this Sep 19, 2024
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Sep 19, 2024
@mihaiplesa mihaiplesa merged commit 0d7e924 into master Sep 19, 2024
11 of 17 checks passed
@mihaiplesa mihaiplesa deleted the revert-update-multihash-crate branch September 19, 2024 17:04
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants