Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable about credits generation #25673

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Commits on Sep 20, 2024

  1. Enable about credits generation

    The whole about credit process validation has now been guarded behind a
    flag in upstream code, which only gets enabled in official builds. This
    has allowed broken PRs to get through master. This change enables the gn
    value for all builds, so breakage can be detected as early as possible.
    
    Chromium change:
    https://chromium.googlesource.com/chromium/src/+/05db21cd6bc1decb3e90ca5eb152d7cea3bae19c
    
    commit 05db21cd6bc1decb3e90ca5eb152d7cea3bae19c
    Author: Fumitoshi Ukai <ukai@google.com>
    Date:   Fri Aug 2 03:01:45 2024 +0000
    
        add gn arg `generate_about_credits`
    
        licenses.py is too slow on cog.
        allow disable about:credits generation.
    
        Bug: 355567690
    cdesouza-chromium committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3ae18a3 View commit details
    Browse the repository at this point in the history