Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards check includes #25685

Open
wants to merge 11 commits into
base: rewards_api_deps
Choose a base branch
from
Open

Conversation

bridiver
Copy link
Collaborator

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

[puLL-Merge] - brave/brave-core@25685

Description

This PR reorganizes and refactors the Brave Rewards component, moving some functionality from the browser layer to the components layer and updating dependencies. It also includes some code cleanup and simplification.

Changes

Changes

  1. browser/brave_rewards/BUILD.gn:

    • Added new source sets for brave_rewards and brave_rewards_impl
    • Moved some sources from the deleted sources.gni file
    • Updated dependencies
  2. browser/brave_rewards/rewards_service_factory.cc:

    • Updated constructor for RewardsServiceImpl
    • Added setup for BraveRewardsSource
  3. browser/brave_rewards/rewards_tab_helper.cc and .h:

    • Introduced a BrowserListObserver class to handle browser-related events
    • Updated RewardsTabHelper to use the new BrowserListObserver
  4. browser/extensions/BUILD.gn:

    • Updated dependencies and sources
  5. browser/greaselion/BUILD.gn:

    • Created a new greaselion source set
  6. browser/sources.gni:

    • Removed references to deleted source files
    • Updated dependencies
  7. browser/ui/BUILD.gn:

    • Created separate source sets for brave_tab_prefs, brave_tab_features, and brave_rewards_source
  8. components/brave_rewards/browser/BUILD.gn:

    • Updated dependencies and sources
  9. components/brave_rewards/browser/rewards_service_impl.cc and .h:

    • Updated constructor to take more specific parameters instead of Profile
    • Replaced profile_ with prefs_ and favicon_service_
    • Removed some unnecessary includes
  10. components/brave_wallet/common/BUILD.gn:

    • Updated dependencies

Possible Issues

  • The refactoring of RewardsServiceImpl to use more specific parameters instead of Profile might require updates in other parts of the codebase that create or use RewardsServiceImpl instances.
  • The introduction of the BrowserListObserver in RewardsTabHelper might change the behavior of browser-related event handling, which should be carefully tested.

Security Hotspots

No significant security hotspots were identified in this change.

@bridiver bridiver changed the base branch from master to rewards_api_deps September 21, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant