Migrate brave-core changes from Android Ads #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
kylehickinson
requested changes
Jul 18, 2019
| ~NotificationInfo(); | ||
|
|
||
| const std::string ToJson() const; | ||
| Result FromJson( | ||
| const std::string& json, | ||
| std::string* error_description = nullptr); | ||
|
|
||
| std::string id; |
There was a problem hiding this comment.
Should add this property to BATAdsNotification
| // Should be called when Ads are enabled or disabled on the Client | ||
| virtual void Initialize() = 0; | ||
| // Should be called when Ads is enabled on the Client | ||
| virtual void Initialize(InitializeCallback callback) = 0; |
There was a problem hiding this comment.
You changed the Initialize signature but I don't see a change to how its called in BATBraveAds.mm as seen here:
| // Should be called when the browser enters the foreground | ||
| virtual void OnForeground() = 0; | ||
| // Should be called when Ads is disabled on the Client | ||
| virtual void Shutdown(ShutdownCallback callback) = 0; |
There was a problem hiding this comment.
We will want to add this call here:
|
Closing and reopening #5160 as not picking up branch changes |
tmancey
force-pushed
the
issues/5160
branch
8 times, most recently
from
92b9390 to
83a9deb
Compare
kylehickinson
approved these changes
Jul 18, 2019
kylehickinson
previously approved these changes
Jul 18, 2019
bsclifton
previously approved these changes
Jul 18, 2019
…emoved from storage
…interaction when destroying AdsImpl
kylehickinson
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#5160
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
default/ads_servicestate is removed when ads are switched offdefault/ads_servicestate is created when ads are switched onReviewer Checklist:
After-merge Checklist:
changes has landed on.