Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single card #3072

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Single card #3072

merged 2 commits into from
Aug 1, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 1, 2019

Resolves brave/brave-browser#5427

Submitter Checklist:

Test Plan:

Test plan 1:

  • enable rewards
  • verify wallet with new uphold account
  • go to uphold account and make sure that card is on the first place and is starred

Test plan 1:

  • enable rewards
  • verify wallet with existing uphold account (need to have at least one BAT card from Brave)
  • go to uphold account and make sure that no new card was created and first card from the list was picked when connecting

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.70.x - Nightly milestone Aug 1, 2019
@NejcZdovc NejcZdovc requested review from tmancey and emerick August 1, 2019 16:14
@NejcZdovc NejcZdovc self-assigned this Aug 1, 2019
emerick
emerick previously approved these changes Aug 1, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emerick
emerick previously approved these changes Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User wallets: brave browser creating multiple wallets
2 participants