Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.69.x] allow shields read-only view to show actual resources blocked #3077

Merged
merged 1 commit into from
Aug 5, 2019
Merged

[0.69.x] allow shields read-only view to show actual resources blocked #3077

merged 1 commit into from
Aug 5, 2019

Conversation

cezaraugusto
Copy link
Contributor

uplift request for #2987 so bug brave/brave-browser#5355 could land in 0.69.x.

@yrliou @cezaraugusto
Merge pull request #2987 from brave/ca-5355
78ab1b3 
allow shields read-only view to show actual resources blocked
@cezaraugusto cezaraugusto added this to the 0.69.x - Dev milestone Aug 1, 2019
@cezaraugusto cezaraugusto requested a review from a team August 1, 2019 20:51
@cezaraugusto cezaraugusto self-assigned this Aug 1, 2019
@cezaraugusto cezaraugusto changed the title allow shields read-only view to show actual resources blocked [0.69.x] allow shields read-only view to show actual resources blocked Aug 1, 2019
kjozwiak
kjozwiak approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers 👍Both CI/Jenkins & CI/Travis both passed. Please make sure that all the correct labels are being used and the appropriate issue is moved into the correct milestone.

@bsclifton bsclifton merged commit a73bb6b into 0.69.x Aug 5, 2019
@bsclifton bsclifton deleted the ca-5355-69 branch August 5, 2019 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
0.69.x-backup
Development

Successfully merging this pull request may close these issues.
4 participants
@cezaraugusto @kjozwiak @bsclifton @yrliou