Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
This PR depends on #3002Fixes cosmetic filtering for tabs loaded in background
Fix brave/brave-browser#5215 (blocking in background tabs)
Fixes stylesheet injection for cosmetic filtering
Fix brave/brave-browser#3041
Fix brave/brave-browser#4348
Fix brave/brave-browser#4338
address brave/brave-browser#94 (comment)
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Background tabs
Open http://raymondhill.net/ublock/adbox.html
Right click, enter
.ADBox
in the fieldBookmark page
Right click bookmark and open as a tab
Switch to new tab and verify that the element is blocked when you switch to it
Cosmetic filtering stylesheet injection
Block element with !important html tag or is asynchronously added to the webpage (ex. reddit/facebook with filters added) and see that those ads are blocked.
.ADBox
filter!important
), PR will..promotedlink
to filterReviewer Checklist:
After-merge Checklist:
changes has landed on.