Initial implementation of P3A (Privacy-Preserving Product Analytics) #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
force-pushed
the
p3a
branch
5 times, most recently
from
e23a005
to
aceefc0
Compare
bsclifton
added
CI/skip
jsecretan
previously approved these changes
Aug 29, 2019
diracdeltas
reviewed
Aug 29, 2019
diracdeltas
reviewed
Aug 29, 2019
|
@bsclifton here is the final text in a screen shot
|
|
text: Brave Shields blocks the creepy stuff that tries to track you across the web — including most ads. Set Shields to “down” if a site doesn’t seem to be working. Brave uses completely private product analytics to estimate the overall usage of certain features. You can turn this off in Settings. |
iefremov
reviewed
Sep 2, 2019
iefremov
reviewed
Sep 2, 2019
|
Ready for re-review 😄 |
|
Reviewing the CI for the last run:
Going to restart it here... |
bsclifton
added
CI/skip-android
|
I pulled down the code locally and was able to reproduce the unit tests failing @iefremov can you check this out? |
|
UPDATE: Linux and macOS passed great 🎉 Seems CI on Windows isn't running? |
bsclifton
added
CI/skip-linux
CI/skip-macos-x64
bridiver
approved these changes
Oct 2, 2019
This was referenced Oct 2, 2019
33 tasks
32 tasks
bsclifton
added a commit
that referenced
this pull request
Dec 9, 2019
… is in sync For example, if you had two windows with brave://settings/privacy open Fixes brave/brave-browser#7289 This is something I missed while implementing #3242
This was referenced Dec 10, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6285
More details on our blog here:
https://brave.com/privacy-preserving-product-analytics-p3a/
Detailed list of the questions here:
https://github.com/brave/brave-browser/wiki/P3A
Quick description
This pull request will implement checks for those answers and (if enabled) will send the answers anonymously (see blog post for more details).
The answers are always collected, whether the service is on or off. They are stored as a
local_statevariable (ex: not part of the profile, not synced, etc). However, the answers only leave the users machine if they have the preference enabled.New user experience
Existing user experience
Disableand it will immediately disable the service and close the infobarGot itor clicking the X will acknowledge this and close the infobarLearn morewill go to the blog postSubmitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
There is a bunch of command-line switches suitable to simplify the testing process (see https://github.com/brave/brave-core/blob/master/components/p3a/brave_p3a_switches.h), as well as detailed logs enabled as follows
--vmodule=*/p3a/*=3 --enable-logging=stderrThe possible command-line for testing might look as follows:
brave --vmodule=*/p3a/*=3 --enable-logging=stderr --p3a-upload-interval-seconds=5 --p3a-rotation-interval-seconds=160 --p3a-upload-server-url="http://127.0.0.1/" --p3a-ignore-server-errors --p3a-do-not-randomize-upload-intervalReviewer Checklist:
After-merge Checklist:
changes has landed on.