-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow navigation via tab key in welcome page #3300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keyboard navigation works great! However, having a hard time seeing the outline in dark mode.
Light mode seems fairly easy to see the orange outline, but here's a clip of tabbing around in dark mode:
- outlines for the bullets are barely visible
Skip welcome tour
does not show any kind of focus (this is the last thing I navigate to and press space, which launches into a new tab)
@bsclifton thanks for reviewing, updated |
|
||
export default interface IThemeWelcomePage { | ||
color: { | ||
outlineColor: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like something that would be useful for all brave components. Is there a reason outline color would be something that welcome page would have only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be useful for all brave features but adding this global default here seems outside of this PR's scope. I'm happy to do that in a follow-up task where we move our brave-core themes to this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's outside of this PR scope since this is the first PR that's adding this value. Either way requires a new brave-ui version - allowing for separate layer of themes (which you've discovered is problematic and requires using the drastic any
step, thereby removing all type checking for theme props), or simply adding this new property.
fix brave/brave-browser#5504 Welcome page navigation via tab is impossible without this change since all non-visible content is hidden visually but still accessible via keyboard. This change fixes it and improves other element focus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUCH better - looking good! 😄
Support widevine linux with bundle w/o default shipping
Support widevine linux with bundle w/o default shipping
Support widevine linux with bundle w/o default shipping
fix brave/brave-browser#5504
Welcome page navigation via tab is impossible without this change since all non-visible content is hidden visually but still accessible via keyboard. This change fixes it and improves other element focus.
Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.