-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new Monthly Banner Variant to tipping process #3429
Conversation
a735a3d
to
79500df
Compare
b770dcf
to
5eee878
Compare
2b4485e
to
044391b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- spacing at the bottom is soo small
-
clicking on contribution date in the banner shouldn't trigger button click
-
when you click on select 0 BAT is always selected and not your actual amount
-
send a tip is not working
[56385:775:0918/075850.531083:ERROR:CONSOLE(0)] "Error handling response: TypeError: Error in invocation of braveRewards.tipSite(integer tabID, string publisherKey, boolean monthly): No matching signature.
at chrome-extension://jidkidbbcafjabdphckchenhfomhnfma/out/brave_rewards_panel.bundle.js:1656:37", source: chrome-extension://jidkidbbcafjabdphckchenhfomhnfma/brave_rewards_panel.html (0)
0d083bd
to
7f17dce
Compare
|
b452540
to
088eb1c
Compare
5e61160
to
6b69a03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to polish tip banner as spacing is off a little bit, but this PR looks good
Fixes: brave/brave-browser#5996
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Defined in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.