Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads are not shown due to compressed resources failing to load #3520

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 24, 2019

Fixes brave/brave-browser#6139
Uplift request for #3515

@tmancey tmancey added this to the 0.71.x - Dev milestone Sep 24, 2019
@tmancey tmancey requested a review from a team September 24, 2019 19:57
@tmancey tmancey self-assigned this Sep 24, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Looks like npm audit_deps is failing on both CI/Jenkins and CI/Travis due to the handlebars package which is a known issue and not related to this PR.

Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@tmancey tmancey merged commit bdcbee1 into 0.71.x Sep 26, 2019
@tmancey tmancey deleted the issues/6139-0.71.x branch September 26, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants