Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect other_node() to bookmark_bar_node() in bookmarks::GetBookmarkNodeByID #3778

Merged
merged 2 commits into from
Oct 24, 2019

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 23, 2019

fix brave/brave-browser#6578

Submitter Checklist:

Test Plan:

Create with default parent

  1. Open chrome://bookmarks/
  2. Open Developer Tools and go to console
  3. Enter chrome.bookmarks.create({title": "brave", "url":"https://brave.com"})
  4. Bookmark should show up in bookmark bar

Create with other_node specified

  1. Open chrome://bookmarks/
  2. Open Developer Tools and go to console
  3. Enter chrome.bookmarks.create({"parentId": "2", "title": "brave", "url":"https://brave.com"})
  4. Bookmark should show up in bookmark bar

Move

  1. Open chrome://bookmarks/
  2. Add bookmark through context menu with title == "brave" and url == "https://brave.com"
  3. Open Developer Tools and go to console
  4. Enter
chrome.bookmarks.search({'title': 'brave'}, (results) => {
  results.forEach((result)=> {
    chrome.bookmarks.move(result.id, {'parentId': '2'})
  })
})
  1. Bookmark should remain in bookmark bar

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@darkdh darkdh self-assigned this Oct 23, 2019
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works good 👍

@darkdh
Copy link
Member Author

darkdh commented Oct 24, 2019

macos and ios have ImportError: No module named httplib2 when running lint
and Publish xUnit test result report failure
Otherwise, all green

@darkdh darkdh merged commit edd63cf into master Oct 24, 2019
@darkdh darkdh deleted the bookmark-api branch October 24, 2019 00:43
@darkdh darkdh added this to the 0.73.x - Nightly milestone Oct 24, 2019
darkdh added a commit that referenced this pull request Jan 28, 2020
This reverts commit edd63cf, reversing
changes made to c7202dc.
darkdh added a commit that referenced this pull request Feb 8, 2020
This reverts commit edd63cf, reversing
changes made to c7202dc.
darkdh added a commit that referenced this pull request Feb 20, 2020
This reverts commit edd63cf, reversing
changes made to c7202dc.
jonathanKingston pushed a commit to jonathanKingston/brave-core that referenced this pull request Mar 11, 2020
This reverts commit edd63cf, reversing
changes made to c7202dc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create bookmarks from chrome API in 'Bookmarks bar' instead 'Other bookmarks'
3 participants