Redirect other_node() to bookmark_bar_node() in bookmarks::GetBookmarkNodeByID #3778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#6578
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Create with default parent
chrome://bookmarks/
Developer Tools
and go to consolechrome.bookmarks.create({title": "brave", "url":"https://brave.com"})
Create with other_node specified
chrome://bookmarks/
Developer Tools
and go to consolechrome.bookmarks.create({"parentId": "2", "title": "brave", "url":"https://brave.com"})
Move
chrome://bookmarks/
Developer Tools
and go to consoleReviewer Checklist:
After-merge Checklist:
changes has landed on.