Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cookies are not imported from Chrome (uplift to 0.71.x) #3812

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Fix cookies are not imported from Chrome (uplift to 0.71.x) #3812

merged 1 commit into from
Oct 30, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 29, 2019 •
edited by simonhong
Loading

Uplift of #3804

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Oct 29, 2019
@brave-builds brave-builds added this to the 0.71.x - Beta milestone Oct 29, 2019
@simonhong simonhong self-assigned this Oct 29, 2019
kjozwiak
kjozwiak approved these changes Oct 30, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@simonhong simonhong merged commit 842096d into 0.71.x Oct 30, 2019
@simonhong simonhong deleted the pr3804_fix_cookie_import_error_from_chrome_0.71.x branch October 30, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@simonhong simonhong

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @simonhong @brave-browser-releases