Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks model not loaded (uplift to 1.4.x) #4688

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

Uplift of #4588

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kjozwiak
Copy link
Member

QA we'll need to run through #4588 (comment) on Nightly before we can approve this into 1.4.x.

@AlexeyBarabash did you check this on Nightly?

@AlexeyBarabash
Copy link
Contributor Author

@kjozwiak
I checked on Nightly updated build 1.7.4 it is not crashed on those steps.

The test plan requires custom-built installer which has an introduced delay, so it is impossible to test by those steps by QA, so brave/brave-browser#8178 has QA/No label.

I went through steps at #4588 (comment) with own built master (v1.7.5) with a mentioned modification and verified it passes.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Jenkins and CI/Travis passed without any failures. As per #4688, this will be difficult for QA to check. However, it does appear like we have tests to cover this scenario.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 622f80a into 1.4.x Feb 21, 2020
@kjozwiak kjozwiak deleted the pr4588_bookmarks_model_not_loaded_1.4.x branch February 21, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants