Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set INCLUDE_PRIVATE_REGISTRIES instead of EXCLUDE_PRIVATE_REGISTRIES #4836

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Mar 4, 2020

fix brave/brave-browser#8538

i'm not sure what is an appropriate test plan here so please feel free to fill it out @tmancey

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@diracdeltas diracdeltas requested a review from tmancey March 4, 2020 23:00
@diracdeltas diracdeltas self-assigned this Mar 4, 2020
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@tmancey tmancey added this to the 1.7.x - Nightly milestone Mar 4, 2020
@tmancey tmancey merged commit 9c1f108 into master Mar 5, 2020
@tmancey tmancey deleted the fix/ads-private-registries branch March 5, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAT ads libraries should probably set INCLUDE_PRIVATE_REGISTRIES
2 participants