Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes category name is missing from ad history #4914

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Fixes category name is missing from ad history #4914

merged 1 commit into from
Mar 13, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 11, 2020

Resolves brave/brave-browser#8646

Submitter Checklist:

Test Plan:

See brave/brave-browser#8646

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if jenkins is ok

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey
Copy link
Collaborator Author

tmancey commented Mar 13, 2020

iOS failed for unrelated reasons

@tmancey tmancey merged commit 8ee250b into master Mar 13, 2020
@tmancey tmancey deleted the issues/8646 branch March 13, 2020 08:23
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.8.28 Chromium: 80.0.3987.149 (Official Build) nightly (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

Screen Shot 2020-03-24 at 9 49 44 AM

Screen Shot 2020-03-24 at 9 49 54 AM

Screen Shot 2020-03-24 at 9 50 06 AM

Screen Shot 2020-03-24 at 9 50 14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Category name is missing from ad history
5 participants