-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't consider Android releases when doing Desktop bisect #4947
Conversation
50159e4
to
951a25a
Compare
Props to @mbacchi for the patch 😄👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also needed the second part of the diff I sent you that returns the token:
git diff build-bisect.py
diff --git a/script/build-bisect.py b/script/build-bisect.py
index 23cb73460..8810b5256 100755
--- a/script/build-bisect.py
+++ b/script/build-bisect.py
@@ -85,6 +85,8 @@ def get_releases(repo):
if release['draft']:
draft_count = draft_count + 1
continue
+ if 'android' in release['tag_name'] or 'b' in release['tag_name']:
+ continue
tag_name = str(release['tag_name'].strip().replace('v', ''))
tag_names.append(tag_name)
releases[tag_name] = release
@@ -293,6 +295,8 @@ def get_github_token():
if result == 'undefined':
raise Exception('`BRAVE_GITHUB_TOKEN` value not found!')
return result
+ else:
+ return github_token
Without it I got the error:
Exception: {
"documentation_url": "https://developer.github.com/v3",
"message": "Bad credentials"
}
…tter check for version
a587a34
to
2f4d055
Compare
@mbacchi updated! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
No corresponding GitHub issue (doesn't affect browser)
Fixes bisect script problem: