Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes remove publisher channel id containing landing TLD+1 for ad notification confirmations - 1.7.x #5034

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fixes remove publisher channel id containing landing TLD+1 for ad notification confirmations - 1.7.x #5034

merged 1 commit into from
Mar 26, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 24, 2020 •
edited by kjozwiak
Loading

Uplift of #5033
Resolves brave/brave-browser#8833

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team March 24, 2020 14:48
@tmancey tmancey self-assigned this Mar 24, 2020
@tmancey tmancey added this to the 1.7.x - Beta milestone Mar 24, 2020
@tmancey tmancey changed the title Fixes remove publisher channel id for ad notification confirmations Fixes remove publisher channel id for ad notification confirmations - 1.7.x Mar 24, 2020
@tmancey tmancey force-pushed the issues/8833-1.7.x branch from 7f72ab1 to b7cec73 Compare March 24, 2020 14:59
@tmancey tmancey changed the title Fixes remove publisher channel id for ad notification confirmations - 1.7.x Fixes remove publisher channel id containing landing TLD+1 for ad notification confirmations - 1.7.x Mar 24, 2020
@kjozwiak
Copy link
Member

Travis is failing TEST_SUITE=test-security due to the minimist npm package being vulnerable. It's a known issue as per brave/brave-browser#8722 and doesn't block the PR from being uplifted.

kjozwiak
kjozwiak approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. QA has gone through the following PR on Nightly as per #5033 (comment). Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit ef3d8f6 into 1.7.x Mar 26, 2020
@kjozwiak kjozwiak deleted the issues/8833-1.7.x branch March 26, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak