Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload active tab when widevine library is ready to use (uplift to 1.7.x) #5049

Closed
wants to merge 1 commit into from
Closed

Reload active tab when widevine library is ready to use (uplift to 1.7.x) #5049

wants to merge 1 commit into from

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 24, 2020 •
edited by kjozwiak
Loading

Uplift of #4978
Fixes brave/brave-browser#4646

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from simonhong as a code owner March 24, 2020 21:36
@brave-builds brave-builds self-assigned this Mar 24, 2020
@brave-builds brave-builds added this to the 1.7.x - Beta milestone Mar 24, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron, simonhong and srirambv March 24, 2020 21:36
@kjozwiak
Copy link
Member

Restarting Linux due to npm run test -- brave_browser_tests Release --output brave_browser_tests.xml failing as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4978_issue_4646_widevine_1.7.x/1/execution/node/482/log/

18:44:46  1 test crashed:
18:44:46      PerfPredictorTabHelperTest.ScriptBlockHasSavings (../../brave/components/brave_perf_predictor/browser/perf_predictor_tab_helper_browsertest.cc:98)

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels Mar 25, 2020
@bsclifton bsclifton closed this Mar 25, 2020
@bsclifton
Copy link
Member

Closing as QA found an issue; more details to be logged in brave/brave-browser#4646

@bsclifton bsclifton deleted the pr4978_issue_4646_widevine_1.7.x branch March 25, 2020 21:22
@bsclifton bsclifton removed this from the 1.7.x - Beta milestone Mar 25, 2020
@bsclifton bsclifton restored the pr4978_issue_4646_widevine_1.7.x branch March 26, 2020 16:30
@bsclifton bsclifton mentioned this pull request Mar 26, 2020
Merged
4 tasks
@kjozwiak kjozwiak deleted the pr4978_issue_4646_widevine_1.7.x branch March 27, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases