Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump adblock-rust-ffi #5117

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Bump adblock-rust-ffi #5117

merged 1 commit into from
Apr 1, 2020

Conversation

bsclifton
Copy link
Member

Fixes brave/brave-browser#5318

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 1.8.x - Nightly milestone Mar 31, 2020
@bsclifton bsclifton requested review from AndriusA and emerick March 31, 2020 20:00
@bsclifton bsclifton self-assigned this Mar 31, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton
Copy link
Member Author

bsclifton commented Apr 1, 2020

CI looks good- there's an unrelated (I think) browser test failure with rewards:
https://ci.brave.com/job/brave-browser-build-pr/job/bsc-update-adblock-rust-ffi/1/execution/node/661/log/

17:37:15  [  FAILED  ] BraveRewardsBrowserTest.SplitProcessorAutoContribution, where TypeParam =  and GetParam() =  (8622 ms)
17:37:15  [510/510] BraveRewardsBrowserTest.SplitProcessorAutoContribution (8712 ms)
17:37:15  1 test failed:
17:37:15      BraveRewardsBrowserTest.SplitProcessorAutoContribution (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:3111)

@NejcZdovc can you confirm this is known?

@bsclifton
Copy link
Member Author

Created brave/brave-browser#8956 to track the browser test issue. It's happening with other PRs too. We can diagnose in that issue- this should be good to merge 👍

@bsclifton bsclifton merged commit 13f3b87 into master Apr 1, 2020
@bsclifton bsclifton deleted the bsc-update-adblock-rust-ffi branch April 1, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please implement a cookie banner blocker that works like "I don't care about cookies"
2 participants