Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change publisher list interval from 1 to 3 days (uplift to 1.5.x) #5137

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 1, 2020

Uplift of #5129

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 1, 2020
@brave-builds brave-builds added this to the 1.5.x - placeholder milestone Apr 1, 2020
@NejcZdovc NejcZdovc closed this Apr 1, 2020
@NejcZdovc NejcZdovc deleted the pr5129_pub-list_1.5.x branch April 1, 2020 20:37
@NejcZdovc NejcZdovc removed this from the 1.5.x - placeholder milestone Apr 1, 2020
@NejcZdovc NejcZdovc restored the pr5129_pub-list_1.5.x branch April 2, 2020 14:07
@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Apr 3, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 3, 2020

Restarting macOS as test-browser failed as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5129_pub-list_1.5.x/2/execution/node/690/log/.

14:26:15  + open '/Volumes/Brave Browser Nightly/Brave Browser Nightly.app'
14:26:15  LSOpenURLsWithRole() failed with error -600 for the file /Volumes/Brave Browser Nightly/Brave Browser Nightly.app.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2020

16:35:57  [  FAILED  ] CosmeticFilteringEnabledTest.CosmeticFilteringDynamic, where TypeParam =  and GetParam() =  (6619 ms)
16:35:57  [477/477] CosmeticFilteringEnabledTest.CosmeticFilteringDynamic (6866 ms)
16:35:57  1 test failed:
16:35:57      CosmeticFilteringEnabledTest.CosmeticFilteringDynamic (../../brave/components/brave_shields/browser/ad_block_service_browsertest.cc:899)

Looks like test-browser failed due to the above but that's expected because we fixed e04aa54 and didn't fix the tests.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Please make sure that correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit ba438d6 into 1.5.x Apr 4, 2020
@kjozwiak kjozwiak deleted the pr5129_pub-list_1.5.x branch April 4, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants