Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher list improvements (uplift to 1.9.x) #5314

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Publisher list improvements (uplift to 1.9.x) #5314

merged 3 commits into from
Apr 24, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 22, 2020 •
edited by bsclifton
Loading

Uplift of #5301
Uplift of #5355
Uplift of #5356

Fixes brave/brave-browser#9376
Fixes brave/brave-browser#9440
Fixes brave/brave-browser#9441

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from NejcZdovc as a code owner April 22, 2020 15:54
@brave-builds brave-builds self-assigned this Apr 22, 2020
@brave-builds brave-builds added this to the 1.9.x - Beta milestone Apr 22, 2020
@NejcZdovc NejcZdovc removed their request for review April 22, 2020 15:54
@kjozwiak
Copy link
Member

xUnit test results failed to publish on macOS on both test-unit and test-browser. However, these are known intermittent issues and not related to this specific PR.

Win x64 failed due to the node being disconnected as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.9.x/1/execution/node/574/log/:

13:16:07  Cannot contact i-011aaf063de02d23c: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
13:21:08  Could not connect to i-011aaf063de02d23c to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 22, 2020
@kjozwiak
Copy link
Member

Looks like it ran into the same issue re: Agent was removed on Win x64 as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.9.x/2/execution/node/350/log.

16:51:14  Cannot contact i-0da44aec1ffed9395: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
16:56:18  Could not connect to i-0da44aec1ffed9395 to send interrupt signal to process

Hopefully it passes this time as it's later in the day.

@kjozwiak
Copy link
Member

Restarting Win x64 due to init failing as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.9.x/4/execution/node/323/log/.

@bsclifton bsclifton force-pushed the pr5301_publisher-list-improvments_1.9.x branch from 2fafdcb to 5d83416 Compare April 24, 2020 08:49
@bsclifton bsclifton requested review from a team and removed request for bbondy, bsclifton, kjozwiak, rebron and srirambv April 24, 2020 17:59
bsclifton
bsclifton approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit a13a475 into 1.9.x Apr 24, 2020
@bsclifton bsclifton deleted the pr5301_publisher-list-improvments_1.9.x branch April 24, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.9.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases @NejcZdovc