Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import history from Safari #5383

Merged
merged 1 commit into from
May 28, 2020
Merged

Import history from Safari #5383

merged 1 commit into from
May 28, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 27, 2020 •
edited
Loading

Fix brave/brave-browser#8515
Fix brave/brave-browser#8343

image

image

Submitter Checklist:

Test Plan:

See issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.10.x - Nightly milestone Apr 27, 2020
@simonhong simonhong self-assigned this Apr 27, 2020
@simonhong simonhong force-pushed the import_safari_history branch from c8ab38f to c13a37d Compare April 28, 2020 01:28
@simonhong simonhong marked this pull request as ready for review April 28, 2020 03:08
@simonhong simonhong requested a review from bridiver as a code owner April 28, 2020 03:08
@simonhong simonhong force-pushed the import_safari_history branch from c13a37d to c48018f Compare April 28, 2020 03:09
@simonhong simonhong requested a review from mkarolin April 28, 2020 03:27
simonhong
simonhong commented Apr 28, 2020
View reviewed changes
browser/ui/webui/settings/brave_import_data_handler_mac.mm
class ScopedOpenFile {
public:
explicit ScopedOpenFile(const base::FilePath& file_path) {
file_ = base::OpenFile(file_path, "r");
Copy link
Member Author

@simonhong simonhong Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to open files(with r) that need full disk access adds Brave browser to full disk access panel list automatically. This fixes brave/brave-browser#8343

@simonhong simonhong force-pushed the import_safari_history branch from c48018f to 52a76fa Compare April 28, 2020 09:17
@simonhong
Copy link
Member Author

Kindly ping to reviewers :)

bridiver
bridiver reviewed May 5, 2020
View reviewed changes
utility/importer/brave_safari_importer.mm

BraveSafariImporter::~BraveSafariImporter() = default;

void BraveSafariImporter::ImportHistory() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, why are we doing this if chrome already imports the history?

Copy link
Member Author

@simonhong simonhong May 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome's history importing from Safari is broken. filed issue to https://bugs.chromium.org/p/chromium/issues/detail?id=1078626
The reason is Chrome still checks History.plist but that file is not existed anymore and History.db is introduced.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is one we can upstream maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bridiver Do you have more concerns for this PR?

@simonhong simonhong requested a review from bridiver May 12, 2020 00:50
@NejcZdovc NejcZdovc removed this from the 1.10.x - Beta milestone May 15, 2020
@simonhong simonhong added this to the 1.11.x - Nightly milestone May 15, 2020
@simonhong simonhong force-pushed the import_safari_history branch from 52a76fa to b98d98e Compare May 19, 2020 02:28
@simonhong simonhong force-pushed the import_safari_history branch from b98d98e to c9050d2 Compare May 27, 2020 06:36
@simonhong simonhong merged commit dac1e88 into master May 28, 2020
@simonhong simonhong deleted the import_safari_history branch May 28, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

@petemill petemill Awaiting requested review from petemill

@bbondy bbondy Awaiting requested review from bbondy

@mkarolin mkarolin Awaiting requested review from mkarolin

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.11.x - Release #1
4 participants
@simonhong @bridiver @bsclifton @NejcZdovc