Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Promotion notification is not cleared when error happens. #5520

Merged
merged 1 commit into from
May 12, 2020
Merged

[Android] Promotion notification is not cleared when error happens. #5520

merged 1 commit into from
May 12, 2020

Conversation

gdregalo
Copy link
Contributor

Resolves brave/brave-browser#9657.

Submitter Checklist:

Test Plan:

  1. Open the panel.
  2. Before claiming a promotion, turn off internet.
  3. Press "Claim" button.
  4. Observe a message "Oops,something is wrong. Please try again later."

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@gdregalo gdregalo added feature/rewards CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 12, 2020
@gdregalo gdregalo added this to the 1.10.x - Nightly milestone May 12, 2020
@gdregalo gdregalo requested a review from NejcZdovc as a code owner May 12, 2020 00:01
@gdregalo gdregalo self-assigned this May 12, 2020
@gdregalo
Copy link
Contributor Author

Screenshot_20200511-192604

samartnik
samartnik approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SergeyZhukovsky
SergeyZhukovsky approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

NejcZdovc
NejcZdovc approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewards code looks good

@gdregalo gdregalo force-pushed the android-ui-claim-error branch from 9e654f9 to 1ea476d Compare May 12, 2020 20:11
@gdregalo gdregalo merged commit c9602d1 into master May 12, 2020
@gdregalo gdregalo deleted the android-ui-claim-error branch May 12, 2020 20:46
@samartnik samartnik mentioned this pull request May 19, 2020
Closed
@btlechowski btlechowski mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@samartnik samartnik samartnik approved these changes

Assignees

@gdregalo gdregalo

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging this pull request may close these issues.

[Android] Promotion notification is not cleared when error happens
4 participants
@gdregalo @NejcZdovc @SergeyZhukovsky @samartnik